search

hyperledger-labs / Scorex

Scorex 2.0 Core
Apache License 2.0
543 stars 115 forks source link

Keep-Alive flag removed #359

Closed kushti closed 4 years ago

kushti commented 4 years ago

The problem with networking layer of Scorex is that inactive connections are not been aborted.

This PR is introducing the first step to solve this problem, it removes keep-alive flag from socket settings, then OS dropping inactive connections after some time. See https://lilyfeng.wordpress.com/2013/03/23/tcp-connection-and-socket-keep-alive/ for details.

However, independent (and usually more aggressive) internal connections dropping strategy is needed. This will be a topic for another PR.

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 46.984% when pulling aa1d8a1585e3f5e35602e80a5e2b27e4e1094e3a on no-keepalive-flag into d7e57852389666b5121ae8796f223cfd872f11c6 on master.