Simplified check for transaction delivery

hyperledger-labs / Scorex

Scorex 2.0 Core

Apache License 2.0

543 stars 115 forks source link

Simplified check for transaction delivery #368

Closed kushti closed 4 years ago

kushti commented 4 years ago

This PR is introducing relaxed rules for transaction delivery check.

Unlike persistent modifiers, non-delivery for a transaction is not a reason to request it again and penalize a peer for non-delivery, as the transaction can be removed for a good reason from other peer's mempool.

coveralls commented 4 years ago

Coverage remained the same at 46.984% when pulling 01d4efff9abf6122262e547b1579bf8564d0d40f on tx-delivery into 940842af26768fafdec749da19f397490274204d on master.