hyperledger-labs / agora-glass_pumpkin

agora-glass_pumpkin
https://wiki.hyperledger.org/display/labs/Agora
Apache License 2.0
21 stars 11 forks source link

Unnecessary allocations in miller_rabin #14

Closed maurges closed 2 years ago

maurges commented 2 years ago

I'm trying to adapt this crate for no_std (and for use with crypto_bigint), and I'm wondering why in the miller_rabin test do we need to allocate all bases at once, instead of generating them on the fly with iterators?

mikelodder7 commented 2 years ago

It’s not necessary, just haven’t returned to adapt this crate. I’d love to get this to work for crypto-bigint. However crypto-bigint doesn’t have all the necessary algorithms yet.