hyperledger-labs / business-partner-agent

The Business Partner Agent is a SSI wallet and controller based on aries cloud agent python.
https://labs.hyperledger.org/business-partner-agent/
Apache License 2.0
56 stars 49 forks source link

Running under context-path #490

Open Echsecutor opened 3 years ago

Echsecutor commented 3 years ago

I would like to run the BPA under a context path such as e.g. comapnyX in https://example.com/companyX . This makes it easier to run more than one instance of the BPA on the same host, in particular for testing/demo purposes.

Echsecutor commented 3 years ago

In principle it should be possible to set the context path in the application.yml like so https://docs.micronaut.io/latest/guide/configurationreference.html#io.micronaut.http.server.HttpServerConfiguration

Some more fiddling with the login paths is needed (also in the application.yml) and there is an absolute path /login in backend/business-partner-agent/src/main/resources/views/signin.hbs which should be ../login. But basically the above mentioned context-path for micronaut does not seem to work.

I will stop working on this for now and just register more subdomains, but leave the feature request here for discussion.

domwoe commented 3 years ago

This would also include changes for did:web mode since this would affect the did.

did:web:example.com:companyX -> https://example.com/companyX/did.json
frank-bee commented 3 years ago

Nice idea @Echsecutor. If we want to support that , also the helm chart has to be adopted. Currently it has some default configuration for ingress and so based on a "URL suffix" - which is basically the domain or a subdomain: https://github.com/hyperledger-labs/business-partner-agent-chart/blob/main/charts/bpa/values.yaml#L10