hyperledger-labs / business-partner-agent

The Business Partner Agent is a SSI wallet and controller based on aries cloud agent python.
https://labs.hyperledger.org/business-partner-agent/
Apache License 2.0
56 stars 49 forks source link

Error npm error during build #759

Closed MonolithicMonk closed 2 years ago

MonolithicMonk commented 2 years ago

Issue: When attempting to build the BPA image using the Dockerfile at the base of the project, the following npm error is thrown:

npm WARN config --include=optional to include them.
npm WARN config 
npm WARN config     Default value does install optional deps unless otherwise omitted.
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: @vue/cli-plugin-eslint@4.5.15
npm ERR! Found: eslint@7.32.0
npm ERR! node_modules/eslint
npm ERR!   dev eslint@"7.32.0" from the root project
npm ERR!   peer eslint@"^7.5.0 || ^8.0.0" from @babel/eslint-parser@7.17.0
npm ERR!   node_modules/@babel/eslint-parser
npm ERR!     @babel/eslint-parser@"^7.12.16" from eslint-template-visitor@2.3.2
npm ERR!     node_modules/eslint-template-visitor
npm ERR!       eslint-template-visitor@"^2.3.2" from eslint-plugin-unicorn@39.0.0
npm ERR!       node_modules/eslint-plugin-unicorn
npm ERR!         dev eslint-plugin-unicorn@"39.0.0" from the root project
npm ERR!   13 more (@typescript-eslint/eslint-plugin, ...)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer eslint@">= 1.6.0 < 7.0.0" from @vue/cli-plugin-eslint@4.5.15
npm ERR! node_modules/@vue/cli-plugin-eslint
npm ERR!   dev @vue/cli-plugin-eslint@"4.5.15" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: eslint@6.8.0
npm ERR! node_modules/eslint
npm ERR!   peer eslint@">= 1.6.0 < 7.0.0" from @vue/cli-plugin-eslint@4.5.15
npm ERR!   node_modules/@vue/cli-plugin-eslint
npm ERR!     dev @vue/cli-plugin-eslint@"4.5.15" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /root/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2022-06-09T16_52_58_292Z-debug-0.log

Temporary resolution: in the Dockerfile add --legacy-peer-deps to the npm install command

etschelp commented 2 years ago

see also: https://github.com/hyperledger-labs/business-partner-agent/pull/757, #763, we need to upgrade to vue3 at some point

marcelTUB commented 2 years ago

temporary workaround is to downgrade npm to 16.14. by using nvm install 16.14 and nvm use 16.14. It starts to break from version 16.15

etschelp commented 2 years ago

Fixed with workaround: https://github.com/hyperledger-labs/business-partner-agent/pull/771 Followed By: https://github.com/hyperledger-labs/business-partner-agent/issues/763