Wallet Page, verified credentials "DID" is not getting updated

hyperledger-labs / business-partner-agent

The Business Partner Agent is a SSI wallet and controller based on aries cloud agent python.

https://labs.hyperledger.org/business-partner-agent/

Apache License 2.0

56 stars 49 forks source link

Wallet Page, verified credentials "DID" is not getting updated #760

Closed DritonGoxhufi closed 2 years ago

DritonGoxhufi commented 2 years ago

In my wallet the credentials issuer does not get updated if the public profile gets reloaded/updated. reason: the issuer gets only get set when the credential is received not when it gets reloaded/updated

possible solution: update the issuer when reloading partners public profile,

related method where this happens is the HolderManager.resolveIssuer

etschelp commented 2 years ago

TODO's

Do not store the issuer with the BPACredentialExchange
- remove the field in the entity
- do not set the issuer when receiving the credential
- remove the field from the database table
Resolve the issuer when loading the credential
- resolveIssuer() method probably needs moving

etschelp commented 2 years ago

see https://github.com/hyperledger-labs/business-partner-agent/pull/751/commits/89cd9adcf2c3fb7c792cdc5824857e9bb2e57e27

etschelp commented 2 years ago

fixed with https://github.com/hyperledger-labs/business-partner-agent/pull/751