hyperledger-labs / business-partner-agent

The Business Partner Agent is a SSI wallet and controller based on aries cloud agent python.
https://labs.hyperledger.org/business-partner-agent/
Apache License 2.0
56 stars 48 forks source link

Feature/vue3 upgrade #783

Closed marcelTUB closed 1 year ago

marcelTUB commented 2 years ago

Preparations for upgrading vue2 to vue3

schlagtim commented 2 years ago

Thanks for your contribution! It seems like the DCO checks are failing because your commits are not signed off - these commits cannot be merged. Please read the Contributing document in the root directory, particularly the chapter Sign your work.

Your previous commits (apart from the most recent one) cannot be signed-off anymore. The DCO check will always fail if there is at least one unsigned commit. Possible solutions in this situation are:

Whatever solutions you choose, you will probably have to do a force push to overwrite the history here.

To prevent this in the future you usually can activate a "always sign-off commits" option in your IDE (most of them support it) or git tool which I highly recommend.

etschelp commented 2 years ago

We just found out that the support for data tables will be available with vuetify 3.1 see https://github.com/vuetifyjs/vuetify/issues/13479#issuecomment-1115233462

It will probably be a while until this happens, as we rely heavily on data tables, it probably makes sense to do the following: