This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once; it will save you a few review cycles!
If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing to do.
[x] All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this).
[x] Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components.
[x] Added tests for changed code (run scripts/preflight to run tests and check code style).
[x] Prefixed code comments with GitHub nick and an appropriate prefix.
[x] Coding style is consistent with the rest of the framework.
[x] Updated documentation for changed code and new or modified features.
If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
PR template adapted from the Python attrs project.
Signed-off-by: Ryan Koch ryan@indicio.tech
Summary of Changes
Used luxon to convert unix timestamps into dates
Related Issues
https://indicio.atlassian.net/browse/DS-521
Pull Request Checklist
This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once; it will save you a few review cycles!
If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing to do.
Signed-off-byline (we use the DCO GitHub app to enforce this).scripts/preflightto run tests and check code style).If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
PR template adapted from the Python attrs project.