hyperledger-labs / cordentity

The Cordentity app integrates Indy capabilities into the Corda platform.
Apache License 2.0
31 stars 19 forks source link

IndyIssuer.createCredentialDefinition documented behaviour differs from the actual implementation #28

Open voddan opened 5 years ago

voddan commented 5 years ago

Here in the documenting comment it says that createCredentialDefinition "stores [credential definition] to ledger if not exists", which is not what the implementation is doing. https://github.com/hyperledger-labs/cordentity/blob/3f11d7385363318588cd4c985c6c82035a602643/indy-utils/src/main/kotlin/com/luxoft/blockchainlab/hyperledger/indy/wallet/WalletUser.kt#L179

Probably this is an inaccuracy in the documenttaion.