search

hyperledger-labs / fabric-operator

Hyperledger Fabric Kubernetes Operator
Apache License 2.0
66 stars 37 forks source link

Fix the build: Run integration tests with golang 1.18, ginkgo v2.1.4, and gomega v1.19 #70

Closed jkneubuh closed 2 years ago

jkneubuh commented 2 years ago

The recent ginkgo update requires golang 1.18. This PR fixes the build pipeline, which was pinning the test version to 1.17.

Signed-off-by: Josh Kneubuhl jkneubuh@us.ibm.com

jkneubuh commented 2 years ago

This is / was a real mess.

running go get github.com/onsi/gomega/... was forcing an upgrade to a logging package shared by controller-gen, fabric-operator, and ginkgo v2. This caused the build to break when running with golang 1.18.

With this PR, the integration tests now run with golang 1.18. The ginkgo binary installs at the latest v2.1.4, but using the older gomega v1.19.0 as specified in the go.mod.

PR #64 needs some work to sort out all of the dependencies - it forces an update of controller-gen, fabric-ca, and logging, which are all intertwined with some odd relationship based on code that may or may not be in the latest 1.5 CA.