hyperledger-labs / pdo-contracts

Apache License 2.0
3 stars 5 forks source link

Complete several of the utility documents for Jupyter #32

Closed cmickeyb closed 3 months ago

cmickeyb commented 4 months ago

At the request of @prakashngit , combining #33 .

Update tests for groups

Replace invocation of the script for building a local groups and services database with one that uses the public interfaces for the services and groups databases. Move away from "host specific" configuration to a configuration based on the more general site configuration file (i.e. site.toml).

By default, testing will still occur with locally hosted services. Importing a site configuration file from another service provider (which just involves copying the site configuration file to ${PDO_HOME}/etc/sites/${SERVICE_HOST}.toml) enables use of PDO services from any location.

Incorporate new widgets

This adds support for several utility notebooks that can be used for managing a client configuration. The notebooks themselves are included along with a collection of widgets that can be used by contract-specific notebooks. The widgets generally include ones to create lists of available resources (e.g. keys, services, groups), select amongst a list of available resources, and create or update resources.

cmickeyb commented 4 months ago

lots of interesting features. would have to think more about how these get used when we build a demo such as the one that are doing now.

not intended for a demo. more intended for managing information for a pilot.

g2flyer commented 4 months ago

FYI: make -C docker pdo_build_images does not work anymore. However, the issue is in private-data-objects. I thought initially i might be the culprit in review of PDO PR #477 but now noticed that even the old version would have failed. For the all target to work the sgx special build targets would seem to have to be called build_service_sgx (and not as originally build_sgx_serviceor as changed due to my consistency changesgx_build_service`). Let me see if this quick-fix really works and i will create a corresponding PDO PR ...

cmickeyb commented 4 months ago

FYI: make -C docker pdo_build_images does not work anymore. However, the issue is in private-data-objects. I thought initially i might be the culprit in review of PDO PR #477 but now noticed that even the old version would have failed. For the all target to work the sgx special build targets would seem to have to be called build_service_sgx (and not as originally build_sgx_serviceor as changed due to my consistency changesgx_build_service`). Let me see if this quick-fix really works and i will create a corresponding PDO PR ...

i've noticed that we are now superceding "all" as the default target. and in part its because of where we included make.loc. explicitly calling make with a target should fix this. I can add a small commit or we can just handle it separately.

g2flyer commented 4 months ago

i've noticed that we are now superceding "all" as the default target. and in part its because of where we included make.loc. explicitly calling make with a target should fix this. I can add a small commit or we can just handle it separately.

this PR should fix the issue without change here (of course whether target all is the right one here is a different question but all shouldn't fail ...)

cmickeyb commented 4 months ago

Changes look good -- definitely like the disappearance of some skip's (although still many left ;-) -- and after applying locally the pdo-build-target-fix and switching again test-machines as it obscurely fails on machines which do not support AVX -- still think my previous suggestion for a simple test would be useful .. - also builds from standalone repo. However, running it, i run into some issues

  • the inference token issuer notebook creation displays rather than renders [Newly created token issuer](../../instances/inference/user1 tokens/token-issuer_DQLVoj.ipynb), i.e., it is not clickably anymore as in earlier versions
  • pdo env initialization fails for issuer notebook due to No such file or directory: '/project/pdo/run/opt/pdo/bin/pdo-create-service-groups.psh', the rest of that notebook though still worked
  • the "Notebook to Invoke Token Operations" still seemed to have a number of past open comments (e.g., to show in text path to zebra image file on docker) and being too lazy to search that path, i gave up for now and wait until these prior comments are resolved

Presumably these issue are all in the inference notebooks. I need to go through & update them (they did not exist when this PR was submitted). Good catch!

cmickeyb commented 4 months ago

Changes look good -- definitely like the disappearance of some skip's (although still many left ;-)

The only way to get rid of the %%skips is to move entirely to interactive operations. I think this PR introduces many of the widgets necessary to do that, but its still low on my priority list.