cmickeyb
commented
3 months ago looked through the specific commit (12) related to the change. Looks good, only question that I don't fully understand is how we are handling guardian host. especially in the /etc/context file. (and which gets used for regluar tests, without notebooks. In the notebooks, I see that you have set variable guardian_host currently set to local host, and I imagine that the notebook user can set it to any IP:port while running the notebook? If so this solves the problem for notebooks, but I am afraid I dont see how the problem gets solved for regular tests.
you put the guardian into a URL in the context. it was never there before and is not there now. i've preserved the basic logic that you had (except that you assumed service_host == guardian_host).
Update the notebooks to take advantage of the transition to service groups. This should enable significantly more flexibility in selecting services from multiple sites.
Changed some of the way the "root" of a context is handled in order to keep group specification easier. If all of the services groups (eservice, pservice, and sservice) have the same name then a single service group setting is sufficient to pick all. Otherwise, each group can be overridden in the custom bindings.
Fixed line length in several of the notebooks.