search

hyperledger-labs / perun-node

State channel node of the blockchain-agnostic state channels framework Perun.
https://labs.hyperledger.org/perun-doc/
Apache License 2.0
18 stars 12 forks source link

123 rename contacts to idprovider #135

Closed anagha-ks closed 3 years ago

anagha-ks commented 4 years ago

Description

Renamed contacts package to idprovider, which will be more suitable as this package provides a list of off-chain addresses and it's corresponding communication addresses.

Changed contactstest to idprovidertest, contactsyaml to local as this package implements local storage based idprovider. Also changed the types and related variables accordingly. Changes have been made in comments as well as readme.

Category

mprovement

Relevant issue

Closes #123

Testing

All existing tests should pass

Steps to run the tests

Checklist

manoranjith commented 3 years ago

@anagha-ks I think most of the things were updated in the previous iteration of the review. Only thing i noticed is that after renaming Peer to PeerID, some of the function names also can be renamed accordingly. Have made suggestion for the same. I think after we discuss these, this PR should be ready to merge.