Functionality of client package is closely related to initialization
of a session. This can also seen in duplication of many test cases in
integration tests on client.NewEthereumPaymentClient & session.New.
In implementing named errors (#132), a lot of errors in session init
will have to be detected in NewEthereumPaymentClient function.
Hence, to remove the duplication of test cases and for simpler error
handling, these two packages are combined.
Also some of the types defined in perun.go for tying these two
packages together are also moved inside of session package
.##### Category
Implementation Task
Relevant issue
Relates to #132.
Testing
As a part of the refactor the tests in client package and session package have been combined.
Coverage should be the same and all existing tests should pass.
Steps to run the tests
Checklist
[x] Name is added to the NOTICE file, if it is not present already.
Description
Functionality of client package is closely related to initialization of a session. This can also seen in duplication of many test cases in integration tests on client.NewEthereumPaymentClient & session.New.
In implementing named errors (#132), a lot of errors in session init will have to be detected in NewEthereumPaymentClient function.
Hence, to remove the duplication of test cases and for simpler error handling, these two packages are combined.
Also some of the types defined in perun.go for tying these two packages together are also moved inside of session package
.##### Category
Implementation Task
Relevant issue
Relates to #132.
Testing
As a part of the refactor the tests in client package and session package have been combined. Coverage should be the same and all existing tests should pass.
Steps to run the tests
Checklist