In case of non-collaborative close, the concluded event is handled by
the go-perun framework by making a new subscription for the event, in
separate from the one used by watcher. Hence this event need not be
handled by perun-node.
Update the HandleAdjudicator function to ignore this event.
In case of collaborative close, the register event is not received.
Update the HandleAdjudicator function to ignore the event.
Tests to check if channel close notifications are received properly
already exist in "Test_Channel_Close".
Category
Improvement
Relevant issue
Closes #198.
Testing
Existing tests already check for the updated logic for handling adjudicator events.
It has been passing, because the additional scenarios that was handled before never occurred and hence were not causing any problem.
Steps to run the tests
Checklist
[x] Name is added to the NOTICE file, if it is not present already.
Description
In case of non-collaborative close, the concluded event is handled by the go-perun framework by making a new subscription for the event, in separate from the one used by watcher. Hence this event need not be handled by perun-node. Update the HandleAdjudicator function to ignore this event.
In case of collaborative close, the register event is not received. Update the HandleAdjudicator function to ignore the event.
Tests to check if channel close notifications are received properly already exist in "Test_Channel_Close".
Category
Improvement
Relevant issue
Closes #198.
Testing
Existing tests already check for the updated logic for handling adjudicator events.
It has been passing, because the additional scenarios that was handled before never occurred and hence were not causing any problem.
Steps to run the tests
Checklist