Remove hard-coded secondary settle, register - Githubissues

hyperledger-labs / perun-node

State channel node of the blockchain-agnostic state channels framework Perun.

https://labs.hyperledger.org/perun-doc/

Apache License 2.0

18 stars 12 forks source link

Remove hard-coded secondary settle, register #205

Closed manoranjith closed 3 years ago

manoranjith commented 3 years ago

Description

Hard coded secondary logic for settle and register transactions were implemented in go-perun, since they were not working as expected.
But in go-perun/issues/8, it was concluded to add this feature later, when there is a concrete use case.
Now, it is removed, because the hard-coded sleep:
- Does not save any cost, as we work on testnet.
- Doubles the test execution time for session package.

Category

Implementation Task

Relevant issue

Closes #204.

Testing

Test execution time for session package becomes half compared to previous test run.

Steps to run the tests

Checklist

[x] Name is added to the NOTICE file, if it is not present already.
[x] Changes are rebased onto the target branch.