search

hyperledger-labs / yui-ibc-solidity

IBC in Solidity
Apache License 2.0
136 stars 62 forks source link

`validatePortIdentifier` doesn't return false #287

Closed srdtrk closed 4 months ago

srdtrk commented 4 months ago

Shouldn't this function return false if the loop assertion fails?

https://github.com/hyperledger-labs/yui-ibc-solidity/blob/49d88ae8151a92e086e6ca7d27a2d3651889edff/contracts/core/26-router/IBCModuleManager.sol#L116-L147

bluele commented 4 months ago

Thanks! We will fix it soon.