hyperledger-solang / solang

Solidity Compiler for Solana and Polkadot
https://solang.readthedocs.io/
Apache License 2.0
1.28k stars 217 forks source link

Remove balance, transfer, and send from Solana #1574

Closed LucasSte closed 1 year ago

LucasSte commented 1 year ago

These builtins were inefficient because they required traversing the AccountMetas array to find a key and are not necessary on Solana, as we can operate on AccountInfo directly.

codecov[bot] commented 1 year ago

Codecov Report

Merging #1574 (ae3aec0) into main (b6b3f5f) will decrease coverage by 0.09%. The diff coverage is 75.86%.

:exclamation: Current head ae3aec0 differs from pull request most recent head ffaaebf. Consider uploading reports for the commit ffaaebf to get more accurate results

@@            Coverage Diff             @@
##             main    #1574      +/-   ##
==========================================
- Coverage   87.45%   87.36%   -0.09%     
==========================================
  Files         133      133              
  Lines       64138    64105      -33     
==========================================
- Hits        56091    56005      -86     
- Misses       8047     8100      +53     
Files Coverage Δ
src/sema/expression/function_call.rs 88.89% <100.00%> (+0.05%) :arrow_up:
src/sema/expression/member_access.rs 93.73% <100.00%> (+0.07%) :arrow_up:
src/sema/yul/builtin.rs 86.20% <ø> (ø)
src/codegen/expression.rs 95.24% <50.00%> (-0.04%) :arrow_down:
src/codegen/solana_accounts/account_collection.rs 95.58% <0.00%> (-0.26%) :arrow_down:
src/emit/solana/target.rs 94.20% <0.00%> (-0.77%) :arrow_down:

... and 9 files with indirect coverage changes