search

hyperledger-solang / solang

Solidity Compiler for Solana and Polkadot
https://solang.readthedocs.io/
Apache License 2.0
1.27k stars 215 forks source link

Do not fail CI if sections of the code are not covered by tests #1585

Closed seanyoung closed 1 year ago

seanyoung commented 1 year ago

codecov should not fail CI when coverage has increased/stayed the same.

Take this PR for example: https://github.com/hyperledger/solang/pull/1583

It changes one line in a package.json and code coverage comes with bunch of failures.

I am all for increasing code coverage but right now every PR is just impossible to get to pass. It is too much to demand that every changed line has a test, and as a result, all the PRs in https://github.com/hyperledger/solang/pulls are marked as failed. Anyone doing a simple code fix will find it impossible, and larger code changes are even worse.

codecov[bot] commented 1 year ago

Codecov Report

Merging #1585 (ffd3e30) into main (979cad9) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1585   +/-   ##
=======================================
  Coverage   87.40%   87.40%           
=======================================
  Files         133      133           
  Lines       64110    64110           
=======================================
  Hits        56033    56033           
  Misses       8077     8077