hyperledger-solang / solang

Solidity Compiler for Solana and Polkadot
https://solang.readthedocs.io/
Apache License 2.0
1.26k stars 210 forks source link

An expression statement should be followed by ; #1601

Closed seanyoung closed 10 months ago

seanyoung commented 10 months ago

Fixes https://github.com/hyperledger/solang/issues/1600

codecov[bot] commented 10 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (99ecfc0) 88.00% compared to head (053d9e4) 88.00%.

:exclamation: Current head 053d9e4 differs from pull request most recent head d074f3d. Consider uploading reports for the commit d074f3d to get more accurate results

Files Patch % Lines
solang-parser/src/helpers/fmt.rs 0.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1601 +/- ## ========================================== - Coverage 88.00% 88.00% -0.01% ========================================== Files 133 133 Lines 64959 64961 +2 ========================================== Hits 57167 57167 - Misses 7792 7794 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

seanyoung commented 10 months ago

The coverage report says this is not tested, but it is. It works when I run cargo llvm-cov --all-features --workspace locally, even if I remove the temporary files. I would not be surprised if codecov cannot deal with crates properly.

seanyoung commented 10 months ago

I feel like it's becoming inevitable to honor solc version pragmas

Actually https://github.com/hyperledger/solang/pull/1592 switches behaviour based on the version pragma

LucasSte commented 10 months ago

The coverage report says this is not tested, but it is. It works when I run cargo llvm-cov --all-features --workspace locally, even if I remove the temporary files. I would not be surprised if codecov cannot deal with crates properly.

I think the cargo llvm-cov is misconfigured. Solana's repository consists of multiple crates and codecov works properly. Please, note that codecov is just a tool to visualize and store the coverage reports. If it is showing wrong results, it is because we are sending an incorrect report to it.