search

hyperledger-web3j / web3j-solidity-gradle-plugin

Gradle plugin providing tasks to compile Solidity contracts.
Apache License 2.0
21 stars 25 forks source link

Rename setters/getters pathRemapping -> pathRemappings #37

Closed eliquinox closed 3 years ago

eliquinox commented 3 years ago

What does this PR do?

Rename pathRemappings setters/getters

Where should the reviewer start?

SolidigyCompile.groovy

Why is it needed?

To allow the plugin to be used with gradle 7.0 and higher

xaviarias commented 3 years ago

Thanks will release a new version 0.3.1

xaviarias commented 3 years ago

@eliquinox where the tests passing before submitting your PR ? They seem to be all failing:

Could not set unknown property 'pathRemapping' for task ':compileSolidity' of type org.web3j.solidity.gradle.plugin.SolidityCompile.
raphael-shin commented 3 years ago

Thanks will release a new version 0.3.1

Do you mean version 0.3.2? Could I ask about the release schedule?

xaviarias commented 3 years ago

Yes @arron-shin sorry is 0.3.2.

We are having an issue with Openzeppelin contract imports but I believe this week should be released the new version.

eliquinox commented 3 years ago

@xaviarias There are indeed failing tests. I initially ran :testClasess to confirm and that built successfully. After running :test there are indeed failures. Feel free to revert my change if not yet been fixed.

xaviarias commented 3 years ago

@eliquinox yes it has been already fixed in the 0.3.2 release.