search

hyperledger-web3j / web3j

Lightweight Java and Android library for integration with Ethereum clients
https://www.web3labs.com/web3j-sdk
Other
5.1k stars 1.68k forks source link

Support for 712 standard. signTypedData #437

Closed vikmeup closed 3 years ago

vikmeup commented 6 years ago

Do you guys plan to support for https://github.com/ethereum/EIPs/pull/712?

What's the easiest way to implement this?

vikmeup commented 6 years ago

@conor10 can you guide?

ice09 commented 5 years ago

To add to the request, I did this manually here: https://github.com/ice09/onboarding-eip712/blob/master/src/main/java/de/ice09/safesigs/services/SignatureService.java

In general, this should be quite easy to do, as for encode and encodePacked the rules are similar: https://medium.com/@libertylocked/what-are-abi-encoding-functions-in-solidity-0-4-24-c1a90b5ddce8

Of course, convenience methods for ecrecovery of EIP-712 signed data would be huge plus for web3j.

jopasserat commented 5 years ago

There're a few PRs and evolving codebase here FWIW.

Would definitely be great to see that landing in web3j

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

drortirosh commented 3 years ago

web3 is still missing eip-712 support. Can only be supported by external provider (e.g. metamask, portis), which is a shame..

Serpivskyi commented 2 years ago

Any news about eip-712 support?

saugion commented 1 year ago

This should be definitely be included...

davidcalap commented 5 months ago

Any news here? Thanks!