search

hyperledger / anoncreds-clsignatures-rs

Apache License 2.0
7 stars 12 forks source link

Non revocation proof is not compatible with Ursa #37

Open conanoc opened 7 months ago

conanoc commented 7 months ago

Non revocation proof created using anoncreds-clsignatures-rs cannot be parsed with Ursa. See this related issue: https://github.com/hyperledger/aries-framework-swift/issues/79

anoncreds-clsignatures-rs does not set m2 on x_list, while m2 is a mandatory field in ursa.

swcurran commented 7 months ago

This requires a fix to the Indy SDK. The change in the format in the presentation is necessary. As Ursa is archived, and its code migrated to this repo, the change cannot be made in other than the Indy SDK.

It might be possible to code around the issue in the Indy SDK if anyone is interested in taking that path, by altering the presentation to add the extra value required by Ursa.

The (strong) recommendation is to upgrade from the Indy SDK to use the shared components.

conanoc commented 7 months ago

I see. Could you tell me a little more about what is m2 and why it is eliminated?

conanoc commented 7 months ago

This seems to be the PR that removed m2: https://github.com/hyperledger/anoncreds-clsignatures-rs/pull/13

swcurran commented 7 months ago

There was a vulnerability found. We’ll be publishing something about it soon.