hyperledger / anoncreds-clsignatures-rs

Apache License 2.0
7 stars 12 forks source link

Add Clone, PartialEq, Eq implementations for data types #40

Closed andrewwhitehead closed 9 months ago

swcurran commented 9 months ago

What’s the purpose of this update?

andrewwhitehead commented 9 months ago

It mostly makes it easier to derive these traits on types in anoncreds-rs. BigNumber only had a 'try_clone' method before, but it's reasonable to just panic if it runs out of memory trying to create one.

swcurran commented 9 months ago

Hopefully @berendsliedrecht knows that means — doesn’t help my understanding. Perhaps that it gives an option not to clone the data structure when memory is tight?

Why was it put in — there doesn’t seem to be an issue that was raised. Perhaps it addresses an issue in another repo?