search

hyperledger / anoncreds-clsignatures-rs

Apache License 2.0
7 stars 12 forks source link

Update the dependencies to address dependabot PRs #50

Closed swcurran closed 5 months ago

swcurran commented 5 months ago

Triggered by the dependabot PRs to update a select set of dependencies, this PR attempts to update all of the dependencies for the project. Created by applying the one change to Cargo.toml in the dependabot PRs (for num-traits), and then running cargo update, and adding the Cargo.lock to the commit and this PR. Confirmed that all of the changes from the dependentabot PRs (43, 45, 46, 48, 49, 50) are in the update, but many are as well.

Might be too bold a move -- as I see that some of the tests are failing...

swcurran commented 5 months ago

Interestingly, running cargo tests run successfully on my system -- cargo version: 1.73.0 (9c4383fb5 2023-08-26). I'm guessing that is too old.

Errors have to do LET-ELSE handling in Glass Pumpkin.

@andrewwhitehead -- could you take a look? What do we update? Given the recent update you did in glass pumpkin, presumably we want the latest and greatest?

andrewwhitehead commented 5 months ago

It looks like let-else was stabilized in Rust 1.65 and this crate is using 1.63 to run the tests. That could probably be updated to something like "stable 6 months ago" as in anoncreds-rs: https://github.com/hyperledger/anoncreds-rs/blob/44a22edc49275f4ad0ea805ae9b033d86c22b405/.github/workflows/build.yml#L4

swcurran commented 5 months ago

That’s an interesting versioning scheme :-). Looks like it worked…

Did I do that correctly?