hyperledger / anoncreds-rs

anoncreds-rs
https://wiki.hyperledger.org/display/anoncreds
Apache License 2.0
71 stars 52 forks source link

Proposal for the handling of Wrappers -- some in the repo, others outside #15

Open swcurran opened 1 year ago

swcurran commented 1 year ago

Per the AnonCreds Rust Working Group meeting of 2022.11.07, on the topic of Wrappers for the Rust artifacts:

Let's assume (for now) that generated wrappers are not viable. If we are going have hand-crafted wrappers, where do we put them -- in this repo or have them as a separate repo?

Argument to keep them in

Argument to move them out

Proposal:

swcurran commented 1 year ago

@TimoGlastra @andrewwhitehead @blu3beri @dkulic -- let me know if you have strong feelings about this "split" approach of some wrappers in the repo and other wrappers outside. Does anyone prefer either all in or all out?

Thanks

dkulic commented 1 year ago

I agree with the proposal.

genaris commented 1 year ago

I think it is a very reasonable proposal considering where we are and concerns from previous experience, as mentioned in yesterday's call with indy-shared-rs (@andrewwhitehead needing help to properly evaluate a wrapper for a platform he doesn't have access to) and indy-sdk (with a separate react-native wrapper as @TimoGlastra mentioned).

It seems to me that separate repos for wrappers could work better for technologies that the core team do not manage or use for testing frequently. Otherwise, it will be nice to have it in the same repo and force their update on each release.

Also this makes me wonder on a potential confusion for wrappers stored in separate repos: imagine a Java wrapper, would it be called anoncreds-java? What if someone else writes a pure Anoncreds Java implementation? Not our problem now, but would be nice to be clear on that.

swcurran commented 1 year ago

I was thinking it would anoncreds-wrapper-java, or if needed anoncreds-rs-wrapper-java.