search

hyperledger / anoncreds-rs

anoncreds-rs
https://wiki.hyperledger.org/display/anoncreds
Apache License 2.0
73 stars 53 forks source link

Instead of having iOS XC framework, making it a universal XC Framework #201

Open goncalo-frade-iohk opened 1 year ago

goncalo-frade-iohk commented 1 year ago

Hello there.

I would like to propose that instead of having separate libraries for iOS and Mac.

You would probably just have to add the libraries you build for Darwin to the xcframework. This would make the xcframework universal.

 - run: >
          ./build-xcframework.sh aarch64-apple-ios \
                                 aarch64-apple-ios-sim \
                                 x86_64-apple-ios \
                                 aarch64-apple-darwin \
                                 x86_64-apple-darwin \
                                 include
swcurran commented 1 year ago

@blu3beri — what do you think of this idea? Helpful? Tried? Presumably, this would also be good for Askar and Indy-VDR, right?

berendsliedrecht commented 1 year ago

Have not tried this, yet. However the FFI libraries, Python and JavaScript, use the dylib directly and not the xcframework. Making it universal would mean that we still have to publish the dylib separately and the xcframework for iOS would be bigger.

So if we were to do this, I would propose to either add it to the iOS one, making it slightly bigger, or create an additional one which would have everything meaning the iOS one can stay small.

I am also not too experienced with xcframeworks and how they fit in the Apple ecosystem, next to some superficial knowledge, so if I missed something please let me know.