Closed ianco closed 5 months ago
That is weird....
I guess I didn't understand the scope of the change we were doing. Sounds like the scope was beyond the prover_did
validation?
I thought we had to explicitly add support for dev8, but is it automatically picked up?
We need to get a fix in for that ASAP, as this will be a significant break.
@andrewwhitehead @ianco , please coordinate.
It's the change to the URI recognition. It seems like the legacy ID recognition was failing, and it was being recognized as a general URI when it's not really. Seems like another test is needed in the library.
D'oh: https://github.com/hyperledger/anoncreds-rs/blob/main/src/data_types/macros.rs#L47-L48
Can we get a dev9
release so we can test this out?
I can do it tomorrow morning. if you can create A PR to update the version already that'll help! (Otherwise i can also do that tomorrow)
Created and tests are running: #314
Release cooking … https://github.com/hyperledger/anoncreds-rs/releases/tag/v0.2.0-dev.9
I think the fix to the DID validation (#307) broke the revocation registry ID validation, we are seeing these errors now on the aca-py integration tests:
The tests were passing with the
dev7
version but are failing with thedev8
version.