Extra validation for w3c credentials and presentations

hyperledger / anoncreds-rs

anoncreds-rs

https://wiki.hyperledger.org/display/anoncreds

Apache License 2.0

73 stars 51 forks source link

Extra validation for w3c credentials and presentations #325

Closed andrewwhitehead closed 5 months ago

andrewwhitehead commented 5 months ago

Related to #322

swcurran commented 5 months ago

Questions for @TimoGlastra and @andrewwhitehead:

Do we merge this now or wait until the credential side is added?
Do we declare 0.2.0:
- complete now?
- after this is merged?
- after the credential side is added and we merge this and that?
- after the merge AND after we do another dev release?

Lots of options -- what do you think is best?

TimoGlastra commented 5 months ago

Do we merge this now or wait until the credential side is added?

I think we can merge it as is and make improvements. The additions to the credential part do not impact security, but rather allow the holder to already catch an invalid credential.

Do we declare 0.2.0: I think with this PR merged is perfect!