fix(js): update ffi-napi

genaris commented 7 months ago

Updated ffi-napi dependency on JS wrapper in order to fix the incompatibility issue found with newer node.js versions. See https://github.com/nodejs/node/issues/52240#issuecomment-2040598178.

swcurran commented 7 months ago

Any idea on the failed test? Looks unrelated to what you did, but...

genaris commented 7 months ago

Any idea on the failed test? Looks unrelated to what you did, but...

It seems that it already failed on the last commit, around 45 days ago: https://github.com/hyperledger/anoncreds-rs/actions/runs/8031489343/job/21939863984

If we look at the latest successful AnonCreds Lint action, we'll find that it was installing a different rustc version:

Good one:

rustup toolchain install 1.71 --component clippy --component rustfmt --profile minimal --no-self-update
Bad one:

rustup toolchain install 1.73 --component clippy --component rustfmt --profile minimal --no-self-update

This happens because in the CI we are setting RUST_VERSION="stable 6 months ago", which of course is variable unless we find a way to stop the time (which would be great by the way!).

@andrewwhitehead @berendsliedrecht do you think we can stick to 1.71? Or do you find better to see why this format check is failing with 1.73 and fix it?

hyperledger / anoncreds-rs

fix(js): update ffi-napi #331