search

hyperledger / anoncreds-spec

The specification for AnonCreds verifiable credential exchange.
https://hyperledger.github.io/anoncreds-spec/
Apache License 2.0
45 stars 24 forks source link

Remove object's own 'id' property from the anoncreds data models #104

Closed TimoGlastra closed 1 year ago

TimoGlastra commented 1 year ago

As discussed on the AnonCreds implementers call on 2022-11-07, there is no need to add the identifiers to the AnonCreds objects, this is just an external value and a reference to the object.

Discussion: https://github.com/hyperledger/anoncreds-rs/issues/4

swcurran commented 1 year ago

To clarify -- this is the "self" ID for an object.

The task of doing this in the spec should be a pass made for addressing only this issue should be added to the roadmap.

TimoGlastra commented 1 year ago

The task of doing this in the spec should be a pass made for addressing only this issue should be added to the roadmap.

What do you exactly mean with this sentence @swcurran?

swcurran commented 1 year ago

That we need a PR that is specific to addressing this issue in the spec. Removing the items from all the documents. This is an attempt to reduce merge conflicts.

At least I think that is what I meant. I wrote that 4 days ago! 🤣

rodolfomiranda commented 1 year ago

Was that already resolved? I couldn't find the own id property on the objects but the legend that the identifier is dependent on where the object is published and the AnonCreds method used.

swcurran commented 1 year ago

Should be good then. Closing this issue.