search

hyperledger / anoncreds-spec

The specification for AnonCreds verifiable credential exchange.
https://hyperledger.github.io/anoncreds-spec/
Apache License 2.0
45 stars 24 forks source link

Validation of identifiers within AnonCreds objects #111

Closed berendsliedrecht closed 1 year ago

berendsliedrecht commented 1 year ago

@TimoGlastra and I had a discussion about the validation of identifiers used within the anoncreds-rs codebase.

I created a PR https://github.com/hyperledger/anoncreds-rs/pull/25 that removes the creation and internal references to the id property inside the anoncreds object and I extract to a seperate string. With this I also removed the validation of the identifier as my understanding was that any identifier is allowed.

Timo pointed me to a section in the spec, https://hyperledger.github.io/anoncreds-spec/#anoncreds-identifiers , which mentions that identifiers SHOULD be validated.

Now, @swcurran I guess the main question is, do we allow any kind of identifier and remove the validation (and change the part where we SHOULD validate) or can external identifiers only be URIs (or legacy) and we add the validation back?

berendsliedrecht commented 1 year ago

As discussed in 12/12/2022 WG:

  1. Identifiers MUST be validated
  2. Identifier MUST be a URI (will cover current identifiers and legacy).
rodolfomiranda commented 1 year ago

what does validation means in this contexts?

berendsliedrecht commented 1 year ago

Closed by #142