hyperledger / anoncreds-spec

The specification for AnonCreds verifiable credential exchange.
https://hyperledger.github.io/anoncreds-spec/
Apache License 2.0
45 stars 24 forks source link

Remove WQL & define proof request restrictions format #127

Closed TimoGlastra closed 1 year ago

TimoGlastra commented 1 year ago

See #118 for extra context.

This issue focusses on a) the removal of WQL from the AnonCreds specification, and b) defining the allowed fields in the restrictions field of a proof request.

I think for backwards compatibility we should keep the fields ending in _did and only allow them for the legacy indy identifier use case. Other should use the _id variant.

The question is how far we want to go in supporting restrictions in the proof request. I think most aries implementations have only implemented the following:

The current AnonCreds spec has a whole sections on WQL and suggests we can also use:

Implementing the above as well means it will be more like a competitor to the Presentation Exchange protocol that allows advanced filtering.

Either way, I think we shouldn't call it Wallet Query Language, but rather call it something specific to proof request restrictions.

Some other notes:

swcurran commented 1 year ago

I'm working on the Presentation Request section (PR today? probably...) and will remove the WQL there, and agree it needs to be removed from the rest. I don't think rev_reg_id is supported, is it? And even if it is, who cares? :-) I think that the existence of an attribute might be supported.

My plan is to work through the rest of the presentation docs as well.

swcurran commented 1 year ago

Per discussion at AnonCreds spec. meeting 2023.01.09 -- closing, addressed by #128