hyperledger / anoncreds-spec

The specification for AnonCreds verifiable credential exchange.
https://hyperledger.github.io/anoncreds-spec/
Apache License 2.0
45 stars 24 forks source link

Validation of anoncreds objects version #130

Closed berendsliedrecht closed 1 year ago

berendsliedrecht commented 1 year ago

I was curious if there is any validation we have to do, could not find it in the spec, with the anoncreds objects version. Do we allow any string? If we have no intention of validation of versions this can be marked as completed.

TimoGlastra commented 1 year ago

What do you mean with validation of the anoncreds version? Where is this present? Do you have an example?

berendsliedrecht commented 1 year ago

What do you mean with validation of the anoncreds version? Where is this present? Do you have an example?

Yeah should have elobaroted on this further, but I am talking about the version inside an anoncreds object like schema: (I thought it was present in more objects, but only schema it seems).


#[derive(Debug, Clone, Serialize, Deserialize)]
#[serde(rename_all = "camelCase")]
pub struct Schema {
    pub name: String,
    pub version: String, <----
    pub attr_names: AttributeNames,
    pub issuer_id: IssuerId,
}
swcurran commented 1 year ago

Discussed on 2023.01.09 AnonCreds Spec Working Group Meeting -- add note in spec. about Indy using semver, but otherwise, it is just a string, and not validated in AnonCreds.

rodolfomiranda commented 1 year ago

PR created