hyperledger / anoncreds-spec

The specification for AnonCreds verifiable credential exchange.
https://hyperledger.github.io/anoncreds-spec/
Apache License 2.0
45 stars 24 forks source link

Schema version note #142

Closed rodolfomiranda closed 1 year ago

rodolfomiranda commented 1 year ago

Adding a note as discussed in #130 . I've only updated version of schema. However version and ver also appear in Create Presentation Request as:

Having version and ver in the same object looks weird. Was this already discussed?

swcurran commented 1 year ago

Agreed the names are confusing. Is this a good time to change them?

To me, the obvious one to change is the version -- the one set by the verifier. We could use tag as is used elsewhere for the verifier to apply to a presentation request. They can use a semver in the tag if they want -- or anything else.

The concept of ver needs to remain, and while I would prefer it be the full word, I recommend that we keep it as is.

Thoughts?

rodolfomiranda commented 1 year ago

agree. tag is also used in CredDef and RevReg

swcurran commented 1 year ago

Could you please resolve the conflicts @rodolfomiranda ?