hyperledger / anoncreds-spec

The specification for AnonCreds verifiable credential exchange.
https://hyperledger.github.io/anoncreds-spec/
Apache License 2.0
45 stars 24 forks source link

Added validity proofs for eq, ge and aggregate proof #182

Closed aritroCoder closed 9 months ago

swcurran commented 9 months ago

I didn't understand how the validity proof that is processed as per this section is combined with the non-revocation proofs that are also in the presentation. There will be one of those per source credential that have to be processed.

aritroCoder commented 9 months ago

I didn't understand how the validity proof that is processed as per this section is combined with the non-revocation proofs that are also in the presentation. There will be one of those per source credential that have to be processed.

To verify the proof, we need to regenerate the challenge hash at verifier side and match it with the one recieved from prover. The challenge hash is computed by concatinating \mathcal{C}, \mathcal{T} and nonce n_1. \mathcal{C} and n_1 are sent by the holder to verifier, and verfier has to compute \mathcal{T} by using the NRP and validity proofs. That's why at the end of both NRP and validity proofs you would find the line "add these values to \hat{T}", which basically means we are regenerating \mathcal{T}.

mikelodder7 commented 9 months ago

I didn't understand how the validity proof that is processed as per this section is combined with the non-revocation proofs that are also in the presentation. There will be one of those per source credential that have to be processed.

To verify the proof, we need to regenerate the challenge hash at verifier side and match it with the one recieved from prover. The challenge hash is computed by concatinating \mathcal{C}, \mathcal{T} and nonce n_1. \mathcal{C} and n_1 are sent by the holder to verifier, and verfier has to compute \mathcal{T} by using the NRP and validity proofs. That's why at the end of both NRP and validity proofs you would find the line "add these values to \hat{T}", which basically means we are regenerating \mathcal{T}.

Correct

swcurran commented 9 months ago

Reopend pull request accidentally closed. @mikelodder7 — could you please add your approval? Thanks!