search

hyperledger / anoncreds-spec

The specification for AnonCreds verifiable credential exchange.
https://hyperledger.github.io/anoncreds-spec/
Apache License 2.0
45 stars 24 forks source link

Privacy and Security Considerations sections #187

Closed swcurran closed 9 months ago

swcurran commented 9 months ago

The population of the Privacy and Security considerations sections. I was not able to find a lot of source material for this, so much of this is new text. I used several other related specs, including the W3C VC specification for topics to be included. If anyone knows of sources of this material, please add a comment to this PR and I'll see about incorporating that content.

In reviewing this, the main concern should be errors vs. clarifications and additions. Where the sections are insufficiently populated or missing content, we can revise/extend the text. We don't want incorrect information pushed out even temporarily.

Feedback welcome!

swcurran commented 9 months ago

Thanks @wip-abramson -- all comments addressed, except the Proper Noun vs. noun question. My leaning is to go with (improper) nouns, and remove the caps on issuers, verifiers, holders except where required.

swcurran commented 9 months ago

Additional feedback addressed. @mikelodder7 — please take another peek at the updates. Thanks!

swcurran commented 9 months ago

@mikelodder7 — corrections made. Nice catches! Thanks!