Add revocation option to the generated CRED_DEF section

hyperledger / anoncreds-spec

The specification for AnonCreds verifiable credential exchange.

https://hyperledger.github.io/anoncreds-spec/

Apache License 2.0

47 stars 24 forks source link

Add revocation option to the generated CRED_DEF section #32

Closed swcurran closed 2 years ago

swcurran commented 2 years ago

Adds to the Generate and Publish CRED_DEF section what happens when the issuer sets support_revocation to true. Some reorganizing of the CRED_DEF setup section to cover both the without and with revocation.

I did not change all references of CredDef to CRED_DEF, but will likely do that before suggesting this be merged.

swcurran commented 2 years ago

This PR is now ready for review and needed to unblock the PR #36 .

Please review @matt-raffel-kiva @hkny @victormartinez-work

swcurran commented 2 years ago

@matt-raffel-kiva @ArPhil @victormartinez-work -- need another review. I had to merge in the updates from earlier.

swcurran commented 2 years ago

Note: Rather than accepting the suggestions, I applied them in my branch. I'm not quite sure that if I accept the suggestion via the UI that I will be able to properly DCO the resulting commit, and once DCO is broken, I generally have to cancel and resubmit the PR.

Ready for another review.