search

hyperledger / anoncreds-v2-rs

Anonymous Credential Exchange 2.0
Apache License 2.0
34 stars 12 forks source link

main branch does not compile #27

Open haroldcarr opened 3 months ago

haroldcarr commented 3 months ago 
> git clone git@github.com:hyperledger/anoncreds-v2-rs.git
Cloning into 'anoncreds-v2-rs'...
...
> cd anoncreds-v2-rs
> cargo test
    Updating crates.io index
    Updating git repository `https://github.com/cryptidtech/bulletproofs`
   Compiling proc-macro2 v1.0.86
   ...
   Compiling bulletproofs v4.0.0 (https://github.com/cryptidtech/bulletproofs#7c5ffd38)
   Compiling credx v0.1.0 (/private/tmp/anoncreds-v2-rs)
error[E0119]: conflicting implementations of trait `From<blsful::inner_types::Scalar>` for type `claim::scalar::ScalarClaim`
  --> src/claim/scalar.rs:34:1
   |
34 | impl From<Scalar> for ScalarClaim {
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: conflicting implementation in crate `blstrs_plus`:
           - impl From<blsful::inner_types::Scalar> for <blsful::inner_types::Scalar as ark_ff::fields::prime::PrimeField>::BigInt;

... other similar errors
swcurran commented 3 months ago

@mikelodder7 — can you please fix this one ASAP? Thanks. I assume this is from a BLSFul change.

mikelodder7 commented 3 months ago

Blsful hasn’t change in months. Must be something else

swcurran commented 3 months ago

Do you have any bandwidth to look into it? Perhaps not on July 4, but sometime soon? :-)

mikelodder7 commented 3 months ago

Yeah I might today

haroldcarr commented 2 months ago

Does this have anything to do with the problem: 2024-07-09

andrewwhitehead commented 2 months ago

Fix added here: https://github.com/mikelodder7/blstrs/pull/3