hyperledger / aries-agent-test-harness

Aries agent test framework, with agent backchannel support
https://aries-interop.info
Apache License 2.0
60 stars 65 forks source link

Peer DID Interop tests - Peer DID Transition #760

Closed nodlesh closed 7 months ago

nodlesh commented 7 months ago

This PR aims to partially complete #752. This is a draft PR until all ACA-Py tasks are completed below. AFJ tasks and other backchannel updates will be broken out into separate tickets if a ticket doesn't exist for it yet.

AFJ Backchannel Updates

VCX Backchannel Updates

Findy Backchannel Updates?

AFGO Backchannel Updates

nodlesh commented 7 months ago

This PR is ready for review and merge. We may have some help on the AFJ side so it would be good if these enhancements were in main.

These Qualified DID Tests will run in the regular interop pipeline test execution cycle for ACA-py. It will run in the full acapy runset. It will not run for any other runset until the backchannels have be brought up to scope for these tests.

Though these tests work with ACA-Py, we expect some of the test specification like the start parameters, etc to change to be more generalized across frameworks once we start working with AFJ and other frameworks in this test context.

nodlesh commented 7 months ago

The last commit here comments out the DID Peer Methods that ACA-Py doesn't support. Will add them back if and when we support them or another Aries framework does. Also loosened the check for the DID Peer Method to pass of fail a test scenario. The responders DID is just checked to make sure it is qualified, not that it has the same DID Peer Method as the requester.

nodlesh commented 7 months ago

@dbluhm or @swcurran Could I get a quick final approval of this? Would like to merge at this point. Thanks.

swcurran commented 7 months ago

Awesome work! Nice!