search

hyperledger / aries-askar

Secure storage designed for Hyperledger Aries agents.
Apache License 2.0
58 stars 44 forks source link

Auto deleting records from wallet based on expiry_ms. #206

Closed dheerajbudhiraja closed 9 months ago

dheerajbudhiraja commented 9 months ago

We have "expiry_ms" in wallet records, which is right now used to filter out expired records In perform_scan.

But I don't see any provision to auto delete records after expiry time, this can lead to increase in wallet size in long term.

Is there any work going to auto delete or it is supposed to be handled from Aries agent side?

If it needs to be handled in Aries agent, then also we will be needing perform_scan query to return back expired records also which are being filtered out.

swcurran commented 9 months ago

@andrewwhitehead — can you respond to this please?

AFAIK — the deletion of records in Aries Askar should be intiated by the Aries agent. That said, I don’t know where the “expiry_ms” entry comes from and what it is intended to be used for. What sets that data item?

joyride9999 commented 9 months ago

i think that expiry_ms is just to make sure that a query to db returns in a given amount of time and not to autodelete rows after an amount of time

swcurran commented 9 months ago

Hopefully that answers the question. Closing this — feel free to ask for additional details.