search

hyperledger / aries-cloudagent-python

Hyperledger Aries Cloud Agent Python (ACA-Py) is a foundation for building decentralized identity applications and services running in non-mobile environments.
https://wiki.hyperledger.org/display/aries
Apache License 2.0
406 stars 510 forks source link

Snyk container scanning not running on PR #2928

Closed pradeepp88 closed 2 months ago

pradeepp88 commented 5 months ago

https://github.com/hyperledger/aries-cloudagent-python/blob/f9d9baded73e49bb796ded1ed9f327dd98ce1c14/.github/workflows/snyk.yml#L1C1-L7C15

Opening this issue to review the Snyk container scan not being run on every PR as configured.

pradeepp88 commented 5 months ago

@swcurran / @WadeBarnes - can you please check the Snyk account to see if the scans are running there? The Github action shows the last container ran 5 months ago. image

WadeBarnes commented 5 months ago

It does appear to be running: image

pradeepp88 commented 5 months ago

@WadeBarnes thanks for checking. So it is an integration issue with Github to view the results.

Is there a public link to view the Snyk scanning results directly from there?

WadeBarnes commented 4 months ago

@pradeepp88, Submitted a PR here that should fix the Sync Container scanning issues; https://github.com/hyperledger/aries-cloudagent-python/pull/2951

pradeepp88 commented 4 months ago

Thanks @WadeBarnes but still the sarif file is having some config errors and the workflow fails

image
pradeepp88 commented 4 months ago

@WadeBarnes submitted a PR #2961 to fix this issue.

jamshale commented 2 months ago

This fix was merged so I believe this issue can be closed.