hyperledger / aries-cloudagent-python

Hyperledger Aries Cloud Agent Python (ACA-Py) is a foundation for building decentralized identity applications and services running in non-mobile environments.
https://wiki.hyperledger.org/display/aries
Apache License 2.0
405 stars 510 forks source link

👷Publish `aries-cloudagent-bbs` Docker image #3175

Closed rblaine95 closed 1 month ago

rblaine95 commented 1 month ago
sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

rblaine95 commented 1 month ago

@jamshale I should have caught it in #3171, thank you for being so quick to review 🙌

jamshale commented 1 month ago

Will merge after integration tests.

swcurran commented 1 month ago

So what is the impact of this going on after 1.0.0? Any concerns?

jamshale commented 1 month ago

I don't have any concerns. Doesn't affect any of the source code. We'll want to make sure the image is correct if it has been overridden by the bbs currently.

jamshale commented 1 month ago

That might involve deleting the current image and re-running the workflow. I'm not exactly sure.

rblaine95 commented 1 month ago

@jamshale running the workflow manually and specifying the tag as 1.0.0 will overwrite the existing 1.0.0 image without having to do another release

image

jamshale commented 1 month ago

Going to do that now.

rblaine95 commented 1 month ago

Ah, that 403 error, I've seen that happen if it's the first time a package is being pushed. Rerunning the workflow should resolve it.

jamshale commented 1 month ago

I've seen that too. Didn't know re-running it worked.

rblaine95 commented 1 month ago

We (DIDx) had it happen a few times, especially when creating a large number of new packages in a single workflow run.

I think it's a hiccough with the Github API trying to provision new packages... some inconsistent backend state, something async that took just a little too long after creating the new package but before the permissions were configured in time 🤷

jamshale commented 1 month ago

Looks like it's published now :+1: