search

hyperledger / aries-cloudagent-python

Hyperledger Aries Cloud Agent Python (ACA-Py) is a foundation for building decentralized identity applications and services running in non-mobile environments.
https://wiki.hyperledger.org/display/aries
Apache License 2.0
405 stars 510 forks source link

Add di support w/ eddsa-jcs-2022 #3181

Open PatStLouis opened 1 month ago

PatStLouis commented 1 month ago

This PR looks to bring Data Integrity to aca-py over arbitrary json (NOT VC).

It adds a eddsa-jcs-2022 cryptosuite to the vc plugin and 2 routes to the wallet plugin (similar to the jwt sign/verify features).

It also moves the request/response schemas to the models directory of the wallet plugin.

PatStLouis commented 1 month ago

I'm having issue with the poetry lock file after adding the canonicaljson package, I don't recall having issues previously when updating the lock file. I'll keep investigating but any pointers would be welcomed.

PatStLouis commented 1 week ago

@dbluhm this is ready for a final review, I've addressed most of the comments and added 4 unit tests. Do you know how to make SonarCloud happy?

PatStLouis commented 1 week ago

@jamshale can I get a pair of eyes on this pr please?

jamshale commented 1 week ago

I think this looks good 👍

Was the did_key manager stuff needed for this PR or was it an accident?

PatStLouis commented 1 week ago

I think this looks good 👍

Was the did_key manager stuff needed for this PR or was it an accident?

accident, let me fix this

sonarcloud[bot] commented 1 week ago

Quality Gate Failed Quality Gate failed

Failed conditions
74.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud