search

hyperledger / aries-cloudagent-python

Hyperledger Aries Cloud Agent Python (ACA-Py) is a foundation for building decentralized identity applications and services running in non-mobile environments.
https://wiki.hyperledger.org/display/aries
Apache License 2.0
405 stars 510 forks source link

aries_cloudagent/config/logging.py:fileConfig assumes a config file with a handler_timed_file_handler section #3186

Closed rngadam closed 1 month ago

rngadam commented 1 month ago

1.0.0rc6-42-g0c2fb7b49

simple log file config:

 scripts/run_docker start --no-ledger --no-transport --log-level info --log-file /dev/stdout

results in a reference to a non-existing configuration option:

NoSectionError       (note: full exception trace is shown but execution is paused at: <module>)
No section: 'handler_timed_file_handler'
KeyError: 'handler_timed_file_handler'

During handling of the above exception, another exception occurred:

  File "/home/user/repos/aries-cloudagent-python/aries_cloudagent/config/logging.py", line 122, in fileConfig
    cp.set(
  File "/home/user/repos/aries-cloudagent-python/aries_cloudagent/config/logging.py", line 287, in _setup_log_config_file
    fileConfig(
  File "/home/user/repos/aries-cloudagent-python/aries_cloudagent/config/logging.py", line 206, in _configure_logging
    cls._setup_log_config_file(log_config_path, log_file)
  File "/home/user/repos/aries-cloudagent-python/aries_cloudagent/config/logging.py", line 197, in configure
    cls._configure_logging(
  File "/home/user/repos/aries-cloudagent-python/aries_cloudagent/config/util.py", line 19, in common_config
    LoggingConfigurator.configure(
  File "/home/user/repos/aries-cloudagent-python/aries_cloudagent/commands/start.py", line 50, in execute
    common_config(settings)
  File "/home/user/repos/aries-cloudagent-python/aries_cloudagent/commands/__init__.py", line 38, in run_command
    module.execute(argv)
  File "/home/user/repos/aries-cloudagent-python/aries_cloudagent/__main__.py", line 64, in run
    run_command(command, args)
  File "/home/user/repos/aries-cloudagent-python/aries_cloudagent/__main__.py", line 75, in main
    run(args)
  File "/home/user/repos/aries-cloudagent-python/aries_cloudagent/__main__.py", line 69, in script_main
    main(sys.argv)
  File "<string>", line 1, in <module> (Current frame)
configparser.NoSectionError: No section: 'handler_timed_file_handler'

code seems to be assuming the existence of a config file with a section handler_timed_file_handler

https://github.com/rngadam/aries-cloudagent-python/blob/0c2fb7b495caf0311adfdbe1d056f426177d3d94/aries_cloudagent/config/logging.py#L121-L133