Add did:indy transaction version 2 support

hyperledger / aries-cloudagent-python

Hyperledger Aries Cloud Agent Python (ACA-Py) is a foundation for building decentralized identity applications and services running in non-mobile environments.

https://wiki.hyperledger.org/display/aries

Apache License 2.0

405 stars 510 forks source link

Add did:indy transaction version 2 support #3253

Open jamshale opened 3 days ago

jamshale commented 3 days ago

This adds the ability to create a did:indy with transaction version 2 algorithm. https://hyperledger.github.io/indy-did-method/#nym-transaction-version.

It's created in a new /did/indy/create endpoint. If the controller tries to create it in the /wallet/did/create endpoint it will get a indy method not supported (same as before) and tell them to use the new endpoint.
Adds seed support with allow-insecure-seed configuration
When starting up an agent wither a did:indy or did:sov seed can be used.
Does a refactor on wallet startup function to reduce complexity.

jamshale commented 1 day ago

The security alerts are nothing. http used in the scenario tests. Not sure how to ignore it yet.

sonarcloud[bot] commented 1 day ago

Quality Gate failed

Failed conditions
2 Security Hotspots

See analysis details on SonarCloud

dbluhm commented 1 day ago

I like what you're doing in this PR -- really appreciate the wallet startup cleanup as well. Question: how do we get the DID onto the ledger? Are we saying this is handled out of band?

jamshale commented 1 day ago

It's the same way as a did:sov. You use the /did/indy/create and then post it to /wallet/did/public. There's no way to start up a fresh agent with a seed and a did:indy currently. Doing that with a seed still creates a did:sov.

Edit: oh, to get it on the ledger you just post the did:indy:12345 and the verkey. So, yes I think that would be out of band.