search

hyperledger / aries-rfcs

Hyperledger Aries is infrastructure for blockchain-rooted, peer-to-peer interactions
https://hyperledger.github.io/aries-rfcs/
Apache License 2.0
324 stars 218 forks source link

RFC 0511 - Missing transition in 0453 from Receive request-credential to Send offer-credential #539

Open awoie opened 3 years ago

awoie commented 3 years ago

RFC 0511 currently says:

This allows the Holder to initiate the issue-credential protocol with a request-message providing they also possess the requisite challenge and domain values. If they do not possess these values then the Issuer MAY respond with an offer-credential message.

The state machine in RFC 0453 does not have a transition from Receive request-credential to Send offer-credential.

llorllale commented 3 years ago

@swcurran we should update RFC0453 with a state matrix....

There's a note that says the choreography diagram represents just the "happy path".

Is there a reason why a transition for the Issuer from request-received -> offer-sent would be disallowed?

swcurran commented 3 years ago

The expectation is that any negotiation around issuance would occur with the "proposal" and "offer" messages, and once that was completed, the flow would go to "request" and "issue". It was deliberate that there not be a "request" to "offer" path, so this is not an oversight. I think that there should be a discussion to see if that should be changed.

Given that and the extra interactions in the DIF model (which admittedly I still don't fully understand), would it make sense to make more use of the proposal (and offer) message for the interactions that cover the "proof" part of DIF issuing?