search

hyperledger / aries-rfcs

Hyperledger Aries is infrastructure for blockchain-rooted, peer-to-peer interactions
https://hyperledger.github.io/aries-rfcs/
Apache License 2.0
326 stars 218 forks source link

RFC 0453 - missing credentials attachment registry for non-hlindy-zkp-v1.0 (specifically W3C JWT/LD-Proofs) #543

Open awoie opened 4 years ago

awoie commented 4 years ago

RFC 0511 notes:

The Issuer SHOULD set the format to the value that corresponds to the format the credentials are issued in.

Currently, 0453 does not support other credential formats than hlindy-zkp-v1.0.

@llorllale I guess we should add support for a W3C VC format to the registry. We could also add more granular formats that distinguishes between W3C VC JWT and W3C VC LD-Proofs. Not sure if a further distinction between VCs that contain DIDs in the @id property of the credentialSubject is required. Ideally, there is an existing registry that we can link such as DIF Credential Format Designations.

swcurran commented 4 years ago

I just verified that 0453 has DIF and Indy in the attachement registry. See this link and registry tables further on in the RFC - https://github.com/hyperledger/aries-rfcs/tree/master/features/0453-issue-credential-v2#propose-attachment-registry

awoie commented 4 years ago

@swcurran I was referring to this table: https://github.com/hyperledger/aries-rfcs/tree/master/features/0453-issue-credential-v2#credentials-attachment-registry . There, VC formats other than indy are missing. Right?

As far as I understood, that table defines the VC format that is contained in the issue-credential message.

swcurran commented 4 years ago

Got it -- yes. Sorry -- I had thought that @llorllale had added them all. I suspect this is because his team is still working on this one, but I don't know.

llorllale commented 4 years ago

@awoie @swcurran we didn't add RFC0511 to the attachment registry for the issue-credential message because it is out of scope of RFC0511.

The expectation is that the DIF CM will specify the credential formats supported by the issuer. I opened an issue a while back to address this - still no response: https://github.com/decentralized-identity/credential-manifest/issues/15

TimoGlastra commented 2 years ago

Can we close this issue? The original issue has been resolved as there's now a format for JSON-LD credentials. However this hasn't been done using credential manifest.

Now that https://github.com/decentralized-identity/credential-manifest/issues/15 is resolved, is there something we should add to the attachment registry for usage with Credential Manifest?

swcurran commented 2 years ago

That could be done, but I think that is a separate issue. Adding Credential Manifest would (I think) require thinking through how to do so in the context of an Issue Credential protocol, likely in the new form of a new RFC. Given the concept of pre-issuance verification inherent in Credential Manifest, I think such an RFC would have to cover more than just the attachment format, but also the additional handling implied by the CM being used.

I'd say close this issue and if there is interest in getting CM added, let's add a new issue and get the discussion started at the Aries WG calls -- starting with a presentation about the details of CM.

TimoGlastra commented 2 years ago

I'd say close this issue and if there is interest in getting CM added, let's add a new issue and get the discussion started at the Aries WG calls -- starting with a presentation about the details of CM.

Agreed! 👍