Do we need a community update to transition to new DIDComm message mime-type?

hyperledger / aries-rfcs

Hyperledger Aries is infrastructure for blockchain-rooted, peer-to-peer interactions

https://hyperledger.github.io/aries-rfcs/

Apache License 2.0

323 stars 217 forks source link

Do we need a community update to transition to new DIDComm message mime-type? #590

Open swcurran opened 3 years ago

swcurran commented 3 years ago

This #571 changed the mime-type for DIDComm messages, and the feeling was that we didn't need to change the frameworks to make this happen.

We did an interop test in the https://github.com/hyperledger/aries-agent-test-harness between ACA-Py and AF-Go and we have a break on mime-type. AF-Go is using application/didcomm-envelope-enc and ACA-Py is using application/ssi-agent-wire and neither is handling the other. We can fix that, by changing both the accept both, but where does that leave Aries Framework .NET and other frameworks?

Do we need to do a community update so that:

all change to handling both and send out the old for awhile
then transition to all sending out the new, and
then change all to drop the first.

We can use Aries Agent Test Harness to find out what Aries Framework .NET is doing and I'll report back here.

@esplinr -- do you know what Evernym is doing?

TimoGlastra commented 3 years ago

Aries Framework .NET uses application/ssi-agent-wire by default

https://github.com/hyperledger/aries-framework-dotnet/blob/517c4d00c3bb100265671340af02c7a949fa00af/src/Hyperledger.Aries/Agents/Transport/DefaultMessageService.cs#L15

swcurran commented 3 years ago

This is why interoperability testing such as we are doing with Aries Agent Test Harness is so important. Despite what is said in the RFCs and the like, things can slip and if we haven't executed tests to demonstrate interop we're going to have to deal with these issues in the wild. And happily, when we do find these issues, we can define an execute a plan to keep interop going.

I'll put a community update RFC together.

@tmarkovski --- can you put a change into Aries Framework .NET so that both mime types are accepted, and then work in the community to get the change rolled out to all of those building on the framework?

tmarkovski commented 3 years ago

Sure. This would be a fairly straightforward change with low impact.

gavetisyanca commented 10 months ago

The same issue is observed on Aries Javascript framework during the connection creation: Unsupported content-type. Supported content-types are: application/ssi-agent-wire, application/didcomm-envelope-enc