search

hyperledger / aries-rfcs

Hyperledger Aries is infrastructure for blockchain-rooted, peer-to-peer interactions
https://hyperledger.github.io/aries-rfcs/
Apache License 2.0
326 stars 217 forks source link

RFC 0510 and RFC 0454 use different format identifiers #762

Closed TimoGlastra closed 1 year ago

TimoGlastra commented 1 year ago

0510 uses dif/presentation-exchange/definition@v1.0 while 0454 uses dif/presentation-exchange/definitions@v1.0 (notice the s).

It seems ACA-Py implemented with the s (from RFC 0454). AFJ has a PR open which also uses the format with the s. Should we update 510 with a note?

TimoGlastra commented 1 year ago

AFGO also uses dif/presentation-exchange/definitions. So it's obvious which to go with I think

swcurran commented 1 year ago

Yes — please add a PR to add the “s”. I think we should be safe in calling it a clarification, but we can discuss that on an Aries Working Group call.

TelegramSam commented 1 year ago

Discussed 20230322. Rodolfo will fix alongside the other issue's PR.

rodolfomiranda commented 1 year ago

fix in https://github.com/hyperledger/aries-rfcs/pull/777